Panics on drop will cause double drops. #3

Activity

1. Stebalien commented on Aug 20, 2015

   

   Stebalien

   on Aug 20, 2015

   Author

   More actions

   Test cases (abusing rust's panic on drop -> abort).

   #[test]
   #[should_panic]
   fn test_drop_panic() {
       struct DropPanic;
   
       impl Drop for DropPanic {
           fn drop(&mut self) {
               panic!("drop");
           }
       }
   
       let mut array = ArrayVec::<[DropPanic; 1]>::new();
       array.push(DropPanic);
   }
   
   #[test]
   #[should_panic]
   fn test_drop_panic_into_iter() {
       struct DropPanic;
   
       impl Drop for DropPanic {
           fn drop(&mut self) {
               panic!("drop");
           }
       }
   
       let mut array = ArrayVec::<[DropPanic; 1]>::new();
       array.push(DropPanic);
       array.into_iter();
   }
2. bluss commented on Aug 20, 2015

   

   bluss

   on Aug 20, 2015

   Owner

   More actions

   Thanks! I guess this won't be easy..
3. Stebalien

   added 2 commits that reference this issue on Aug 20, 2015

   Don't drop twice on panic.

   ...

   This issue will close once commit 34cc319 is merged into the 'master' branch.

   34cc319

   Don't drop twice on panic.

   ...

   This issue will close once commit 9be5400 is merged into the 'master' branch.

   9be5400
4. bluss

   added a commit that references this issue on Aug 20, 2015

   Avoid double drop on panic bug

   ...

   This issue will close once commit 24473a8 is merged into the 'master' branch.

   24473a8
5. bluss commented on Aug 20, 2015

   

   bluss

   on Aug 20, 2015

   Owner

   More actions

   For the lols, please read #5. Hey you said you would leave it for me to fix! But I do think you have the sane version, and I the insane..
6. bluss

   added a commit that references this issue on Aug 20, 2015

   Use NoDrop to fix panic safety issues

   ...

   This issue will close once commit c35760e is merged into the 'master' branch.

   c35760e
7. bluss

   closed this as completedin #6on Aug 21, 2015
8. bluss commented on Aug 21, 2015

   

   bluss

   on Aug 21, 2015

   Owner

   More actions

   Fixed in version 0.3.10. Use (unstable) feature flag nodrop/no_drop_flag to recover size. (However, it's not completely equivalent in terms of overhead, even if the size is the same.)
9. bluss commented on Aug 21, 2015

   

   bluss

   on Aug 21, 2015

   Owner

   More actions

   Great, now it's fixed in smallvec too.