Repository navigation
Feature/mujoco reset localization - #1112
BloodWork44 wants to merge 2 commits into
Conversation
include: subdir: "src/lib/domain_bridge" remote: "ssh://git@github.com/bit-bots/domain_bridge" branch: "main" commit: "a988587e9e664c46710cf90436907b60ee1caea8" git-include-version: 0.1.4
|
I think calling services one to many is a fundermental problem, as they are build to be 1to1 because the caller gets exactly one response. |
|
What do you mean with "one to many"? The simulator does as many individual 1to1 service calls as there are robots, each robot's service gets mapped to a different service in the many domain id. |
|
Ah okay nvm this makes more sense. I only looked at the description not at the code tbh.. |
|
Tested this in multi-robot simulation: localization reset generally works after forcing regeneration of the domain bridge's generated dispatcher. Thanks! It needs the follow-up #1116, stacked on this branch, which imports bit-bots/domain_bridge#1 via git-include. Why: the bridge discovers supported service/action types at build time. Without a declared dependency on The follow-up fixes build ordering, refreshes discovery on each build without rewriting unchanged output, and fails early if the required reset interface is missing. It also adds generator regressions and a remapped cross-domain reset service test; the service tests passed with Cyclone DDS, Fast DDS (static and dynamic), and Zenoh. Please include #1116 before merging this PR so users do not need the manual regeneration workaround. |
Summary
The localization is now notified when the simulator is reset.
Proposed changes
The domain bridge doesn't support services or actions out of the box. ros2/domain_bridge#82 adds this support, which lets us call the localization reset service over the domain bridge.
Related issues
Mujoco Simulator Reset - #852
Checklist
pixi run build