Skip to content

fix: wait for motor feedback before publishing joint states - #1111

Open
jaagut wants to merge 1 commit into
mainfrom
fix/livelybot-initial-joint-states
Open

jaagut wants to merge 1 commit into
mainfrom
fix/livelybot-initial-joint-states

Conversation

@jaagut

@jaagut jaagut commented Oct 24, 2026

Copy link
Copy Markdown
Member

Summary

Wait for feedback from every configured motor before publishing joint_states.

Proposed changes

  • Keep polling motors while any motor state is unknown.
  • Publish only complete joint states, avoiding empty or partial messages with placeholder positions.
  • Add regression tests for delayed, reordered, and subsequent motor feedback.
  • Document the startup behavior in the Livelybot SDK README.

Related issues

No related issue provided.

Checklist

  • Run pixi run build
  • Write documentation
  • Test on your machine
  • Test on the robot
  • Create issues for future work
  • Triage this PR and label it

Prevent startup placeholder positions from seeding the head mover trajectory by withholding joint states until every configured motor has returned feedback. Keep polling while waiting and cover feedback arrival order, initial zero positions, and subsequent updates with hardware-free tests.
@Flova

Flova commented Oct 25, 2026

Copy link
Copy Markdown
Member

Imo missing motors should be dropped from the array, but partial joint states should still be propergared, so a disconnected head motor doesn't crash the walking for example. Publishing default is bad, I agree with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🆕 New

Development

Successfully merging this pull request may close these issues.

2 participants