Repository navigation
The site is served at doc.beffroi.tech - #9
Merged
Merged
Conversation
… read from the version of the page site_url names the domain the CNAME file at the root of gh-pages gives Pages, so the canonical address, the sitemap and the share image of every page are under https://doc.beffroi.tech/<version>/. The share image was read from site_url followed by "latest/", but mike sets site_url to the address of the version without a trailing slash, which gave .../0.1latest/assets/...; it is now read from the version the page belongs to, which carries the same file. The README names the address, and the publication workflow says where the domain is set and why mike leaves it alone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pages already serves the site at https://doc.beffroi.tech/: the
CNAMEfile at the root ofgh-pagesnames the domain, the certificate is approved and HTTPS is enforced. This brings the site's own configuration in line with it.mkdocs.yml:site_urlishttps://doc.beffroi.tech/, so the canonical address, the sitemap and the share image of every page are underhttps://doc.beffroi.tech/<version>/instead ofhttps://beffroi-auth.github.io/docs/<version>/.docs/overrides/main.html: the share image was{{ config.site_url }}latest/.... mike setssite_urlto the address of the version without a trailing slash, so the published pages carriedhttps://beffroi-auth.github.io/docs/0.1latest/assets/images/beffroi-og-image-1200x630.png, an address that does not exist. The image is now read from the version the page belongs to, which carries the same file.README.mdnames the new address, and.github/workflows/pages.ymlsays where the domain is set and why mike never touches that file (it writes only the directories of a version and its aliases, the root redirect andversions.json).Checked with
make check, and with amike deployof 0.1 into a local throwaway branch: canonicalhttps://doc.beffroi.tech/0.1/andhttps://doc.beffroi.tech/0.1/oidc/, sitemaphttps://doc.beffroi.tech/0.1/, share imagehttps://doc.beffroi.tech/0.1/assets/images/beffroi-og-image-1200x630.png, which answers 200 today.