This repository was archived by the owner on Aug 7, 2024. It is now read-only.
Repository navigation
Fix to upload video/gifs to correct endpoint if filesize < self.chunk_size - #439
Merged
Merged
Conversation
…_size previously, if a gif or a video (mp4/quicktime) was less than self.chunk_size, it would be uploaded via UploadMediaSimple, but this was a bug because that endpoint cannot handle videos or gifs. closes #433
Codecov Report
@@ Coverage Diff @@
## master #439 +/- ##
==========================================
+ Coverage 74.84% 74.91% +0.06%
==========================================
Files 8 8
Lines 1944 1945 +1
==========================================
+ Hits 1455 1457 +2
+ Misses 489 488 -1
Continue to review full report at Codecov.
|
Owner
|
Reviewed 3 of 3 files at r1. Comments from Reviewable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if a GIF or a video was less than
self.chunk_size, it would be uploaded viaUploadMediaSimple, but this was a bug because that endpoint cannot handle videos or GIFs. This change makes it so that even if the video is small, it'll get passed toUploadMediaChunked.Closes #433. All tests pass.
This change is