Skip to content
This repository was archived by the owner on Aug 5, 2021. It is now read-only.
This repository was archived by the owner on Aug 5, 2021. It is now read-only.

GIL audit? #162

Open
Open

Description

@devinrsmith

I'm not an expert on the GIL / Python C api, but the documentation suggests that every single API call needs to be executed within the context of a held GIL lock: "... only the thread that has acquired the GIL may operate on Python objects or call Python/C API functions."

I've noticed a few places where the GIL isn't being acquired: Java_org_jpy_PyLib_newDict and Java_org_jpy_PyLib_copyDict (a non-exhaustive search). Should these places acquire the GIL?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions