Skip to content
This repository was archived by the owner on Apr 23, 2026. It is now read-only.
This repository was archived by the owner on Apr 23, 2026. It is now read-only.

How to set --fatal_warnings? #96

Open
Open
How to set --fatal_warnings?#96
Labels
P4This is either out of scope or we don't have bandwidth to review a PR. (No assignee)questionFurther information is requested

Description

@Kernald
Kernald
opened on Aug 24, 2021

Is there a way to enforce that every proto_library target are compiled with --fatal_warnings?

For reference, this flag was added here, and causes the compilation to fail if a warning is raised, like -Werror with GCC.

Activity

  1. comius commented on Feb 8, 2022

    @comius
    comius
    on Feb 8, 2022
    Contributor

    Try using --protocopt=--fatal_warning.

  2. comius
    added
    P4This is either out of scope or we don't have bandwidth to review a PR. (No assignee)
    on Feb 8, 2022

  3. Kernald commented on Feb 8, 2022

    @Kernald
    Kernald
    on Feb 8, 2022
    Author

    --protocopt=--fatal_warnings indeed seems to work. I'm happy to either close this or leave it open to have a way to set this directly in the toolchain configuration in Bazel - not sure what's the most common way to do this kind of things.

  4. Yannic commented on Feb 8, 2022

    @Yannic
    Yannic
    on Feb 8, 2022
    Contributor

    We should have a way to specify protoc-opts in the (not-yet-existing) proto_toolchain in addition to the command-line.

  5. Yannic
    added
    questionFurther information is requested
    on Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P4This is either out of scope or we don't have bandwidth to review a PR. (No assignee)questionFurther information is requested

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions