Skip to content
This repository was archived by the owner on Apr 23, 2026. It is now read-only.
This repository was archived by the owner on Apr 23, 2026. It is now read-only.

Allow to specify --protocopt on per-target basis #230

Open

Description

@auzhva

Problem Statement

In our project, we prefer to enable strict protobuf validations, with --fatal_warnings on for our targets.

Currently, we're not able to do so if any of the third-party libraries have protobuf files with warnings. So we're looking for some logic that would allow us to:

  1. Specify --fatal_warnings for our targets
  2. Leave it disabled for third-parties

Proposed Solution

If we take a look into how CC rules are implemented, there are 2 ways to supply CC options:

  1. --copt global flag that sets an option for everybody
  2. copts attribute of cc_library and cc_binary rules

For protoc, there is --protocopt which is sort of similar to --copt, but there is no way to specify options on a per-target basis. It would be great to see protocopts for the proto_library rule.

Something like:

proto_library(
    name = "sample_proto",
    srcs = ["sample.proto"],
    protocopts = ["--fatal_warnings"], # Here is the added part
    visibility = ["//visibility:public"],
)

Activity

  1. added
    P4This is either out of scope or we don't have bandwidth to review a PR. (No assignee)
    on Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P4This is either out of scope or we don't have bandwidth to review a PR. (No assignee)

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions