Skip to content
This repository was archived by the owner on Apr 23, 2026. It is now read-only.
This repository was archived by the owner on Apr 23, 2026. It is now read-only.

proto_common.compile breaks non-.exe Windows plugins #220

Open

Description

@iamricard

When using proto_common.compile on a Windows host the resulting path passed to plugin_format_flag uses forward slashes. This is fine for .exe, but it breaks for .bat plugins. It seems that because .exe plugins don't use the cmd.exe wrapper Windows can handle them just fine, but plugins with .bat (eg. a js_binary from rules_js) break with an error like 'bazel-out' is not recognized as an internal or external command, operable program or batch file.

Ideally either proto_common.compile or protoc itself would rewrite the plugin path with backslashes as described in https://bazel.build/rules/windows#paths when running on Windows.

cc @Yannic

Activity

  1. added
    P3We're not considering to work on this, but happy to review a PR. (No assignee)
    on Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3We're not considering to work on this, but happy to review a PR. (No assignee)

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions