Repository navigation
fix(server): require opt-in for all-interface binding - #2495
Open
utpalsinghdev wants to merge 1 commit into
Open
utpalsinghdev wants to merge 1 commit into
utpalsinghdev wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SSH detection currently enables remote mode and binds the review server to
0.0.0.0. This makes unauthenticated endpoints reachable from the network,even when the user only needs SSH port forwarding.
This PR keeps SSH-detected sessions on
127.0.0.1in both the Bun server andthe Pi extension. They retain the fixed remote port, browser-opening behavior,
and existing remote feature restrictions.
Binding all interfaces now requires explicit
PLANNOTATOR_REMOTE=1ortrue.Explicit remote mode and the Bun CLI's
--tailscalepublishing remain unchanged.The patch also:
forwarding or a proxy, while preserving public reverse-proxy URLs.
PLANNOTATOR_REMOTEunset insteadof opting users back into all-interface binding.
How this relates to #956
The issue reports several separate security gaps. Two already have fixes on
main:validation across both runtimes.
same-origin guard before routing, covering approval, feedback, agent jobs,
and Ask AI endpoints.
variables alone from exposing the server beyond loopback.
General endpoint authentication remains unresolved. With explicit remote mode
enabled, network clients that can reach the server can still call sensitive
endpoints without a session token. Host and Origin checks are not authentication
for non-browser clients.
Related to #956. This is a partial mitigation, not a complete resolution.
Verification
Host/Origin guards, state-changing routes, and Tailscale Serve orchestration.
packages/shared,packages/server, andapps/pi-extension.runtimes under SSH detection.
127.0.0.1. Loopback requests succeeded;same-machine connection attempts through the LAN and Tailscale addresses
were refused.
text/plainapproval requests returned HTTP 403 in bothruntimes.
git diff --checkpassed.