Repository navigation
Inbox: the attachment pane follows Plannotator's Grid/Clean plan look - #1796
Merged
Merged
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The owner looked at a plan inside the Inbox and asked that it follow Plannotator's own plan look, the "Grid" or "Clean" choice in Plannotator's Settings, instead of the Inbox's own card. The attachment pane now reads the same
gridEnabledsetting Plannotator's windows read (the config registry and its cookieplannotator-grid-enabled, no second setting): Grid draws plan review's card on the grid paper, Clean draws the document edge to edge on the card colour. The default stays the registry's (Grid).What changed
packages/inbox/components/AttachmentPane.tsx:useConfigValue('gridEnabled'); the scroll area takesbg-grid(Grid) orbg-card(Clean), the same classes plan review's document area uses (packages/editor/App.tsx), andViewergetsgridEnabled, so the card chrome (rounded-xl,shadow-xl,border-border/50, padding) is Viewer's own. The width bound moves from.ib-doccardto Viewer'smaxWidth(640 beside the thread, 760 full screen, the record's widths).data-look="grid|clean"on the scroll area for the proof. Applies to markdown, text and diagram attachments (all go throughViewer); HTML is unchanged.packages/inbox/inbox.css:.ib-doccardand its full-screen rule removed;.ib-docscrollcentres the Viewer.tests/e2e/inbox-attachments.spec.ts: a new test (below); the.ib-doccardselectors now read.ib-docscroll.AGENTS.md(Inbox section, attachments): one line on the look.Settings
The Inbox's Settings (
packages/inbox/components/Settings.tsx) lists no look settings (no theme, no plan look): it has the agent-tools knob, connections, notifications, phones and storage. Per the brief it is left alone; the switch stays in Plannotator's Settings, and the cookie is shared across localhost ports, so a change there shows in the Inbox on the next load.Proof
tests/e2e/inbox-attachments.spec.ts, "the plan follows Plannotator's look", Playwright against the compiled binary ininbox-e2e.yml(paths-gated onpackages/inbox/**):true):data-look="grid", the scroll area hasbg-grid, the article hasshadow-xlandborder. Frame2.1b-plan-look-grid-{light,dark}.png.plannotator-grid-enabled=false, reload:data-look="clean",bg-card, noshadow-xl, the article's background equals the scroll area's. Frame2.1c-plan-look-clean-{light,dark}.png.Run:
bun run build:review && bun run build:hook && bun build apps/hook/server/index.ts --compile --no-compile-autoload-bunfig --define '__CLI_VERSION__="0.0.0-dev"' --outfile .local/plannotator && bun run test:e2e:inbox(locally:npx playwright test -c tests/e2e/playwright.config.ts inbox-attachments.spec.ts, 11 passed). Frames copied toresearch/operational/mobile-proofs/INBOX-CLEAN-2026-10-08/in the Workspaces tree.Gates
bun run typecheck: green.bun test packages apps/hook tests scriptsunder a tempPLANNOTATOR_DATA_DIR: 5863 pass, 0 fail.bun run check:release-version: green.packages/uiandpackages/coreunchanged, so nosmoke:package.Deviation from the record
The window record (
.product/approved/plannotator-inbox-window-2026-10-07/, section 2.2) drew the file on the Inbox's own card (10px radius,--card-shadow, on--background). Grid now draws plan review's card instead (12px radius,shadow-xl, a hairline border, on the grid paper), and Clean has no card at all. Reason: the owner's ruling on 2026-10-08 that the plan in the Inbox should be Plannotator's own rendering and follow its Grid/Clean setting. Widths stay the record's.Leaves out
No Inbox-only switch, no Settings row, no change to HTML attachments or message bodies, no plan-width setting (
plannotator-plan-width) reading.