Skip to content

fix(mod): match command.run by command name - #1741

Merged
backnotprop merged 3 commits into
backnotprop:mainfrom
rushelex:rushelex/command-run-matcher
Oct 7, 2026
Merged

backnotprop merged 3 commits into
backnotprop:mainfrom
rushelex:rushelex/command-run-matcher

Conversation

@rushelex

@rushelex rushelex commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #1740.

Matches the mod's command.run hook by Plannotator's command names. Other plugins' command output is no longer labeled +plannotator; claude plugin test apps/hook register tests pass.

🤖 Generated with Claude Code

https://claude.ai/code/session_01LVxwRgsYRcFuYQff6CBo21

rushelex and others added 2 commits October 6, 2026 20:20
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LVxwRgsYRcFuYQff6CBo21
…prop#1740)

A bun test checks register() hooks command.run once, matched on exactly
COMMANDS' names, so dropping the matcher (other plugins' command output
labeled +plannotator) or missing a name (the user's blocking skill runs)
fails. An engine-harness test runs all three commands, one skill-held and
two registered, and a foreign command that passes through untouched.
@backnotprop
backnotprop merged commit 61dd39f into backnotprop:main Oct 7, 2026
24 checks passed
@backnotprop

Copy link
Copy Markdown
Owner

Thanks @rushelex, for the clear report in #1740 and the fix. You were right: matching command.run on Plannotator's own command names is all it needed.

Before merging, we checked it live in Claude Code 2.1.291 with a second plugin. Its output went from plannotator+frontend: … to frontend: …, and /plannotator-annotate, /plannotator-review and /plannotator-last still open without blocking, with or without the user skills installed. We added two tests so the matcher can't quietly go missing later.

It ships in 0.28.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mod: other plugins' command output is labeled +plannotator

2 participants