Repository navigation
chore: remove hardcoded list from pr-labeler workflow - #951
Open
reedham-aws wants to merge 1 commit into
Open
reedham-aws wants to merge 1 commit into
reedham-aws wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes
We currently have a hardcoded list of maintainers in our repositories that determines if the PR is coming from an AWS internal source. Everytime a team member comes or goes, we must update this in all our repos. This PR changes it so that internal versus external is determined by the submitter's permissions in the repo, which are determined by team membership.
Description of how you validated changes
I did not because I didn't think it was worth it to merge this then raise another repo in my fork. I plan on raising a PR to this repo later for a different update and we can see if it works then. If a reviewer feels it's necessary I can test this in a fork.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.