Repository navigation
fix(parser): accept SES events without common headers or invocation type - #8768
Open
Manishram-ai wants to merge 1 commit into
Open
Manishram-ai wants to merge 1 commit into
Manishram-ai wants to merge 1 commit into
Conversation
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue number:
closes #8767
Summary
Changes
SesReceiptAction.invocationTypeacceptsRequestResponseas well asEvent, and is optional. The SES docs list both values, and the captured event in Bug: SesSchema rejects documented SES receipt events powertools-lambda-typescript#5771 doesn't have it.SesMailCommonHeadersis optional now. SES only sends the headers the email has, so an email sent only to BCC recipients has noto.SESEventdata class,toandget_fromreturn[]when the header is missing, likeccandbccalready do.return_path,date,message_id,subjectandinvocation_typereturnNoneinstead of raisingKeyError, so their return types change fromstrtostr | None.This is the same fix as aws-powertools/powertools-lambda-typescript#5772. The
replyTopart of that PR was already done here in #8525.User experience
Today, events from a Lambda action invoked with
RequestResponse, and emails without a To or Subject header, fail with aValidationErrorin the parser and aKeyErrorin the data class. With this change they parse, and the missing headers come back asNone(or[]for the list headers in the data class).Verification
developand pass with this change. TheEventcase already passed.tests/unit/parserandtests/unit/data_classes/required_dependencies: 366 passed (Python 3.12).ruff check,ruff format --checkandmypyare clean on the changed files.invocationTypecomes from the captured event in the TypeScript issue.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.