Maintenance: Monthly reminder to update roadmap #4074

Activity

1. heitorlessa

   added

   triagePending triage from maintainersPending triage from maintainers

   internalMaintenance changesMaintenance changes

   on Apr 5, 2024
2. github-project-automation

   added this to Powertools for AWS Lambda (Python)on Apr 5, 2024
3. github-project-automation

   moved this to Triage in Powertools for AWS Lambda (Python)on Apr 5, 2024
4. heitorlessa

   removed

   triagePending triage from maintainersPending triage from maintainers

   on Apr 5, 2024
5. leandrodamascena

   linked a pull request that will close this issuechore(ci): add monthly roadmap reminder workflow #4075on Apr 5, 2024
6. heitorlessa

   closed this as completedin #4075on Apr 5, 2024
7. github-project-automation

   moved this from Triage to Coming soon in Powertools for AWS Lambda (Python)on Apr 5, 2024
8. github-actions commented on Apr 5, 2024

   

   github-actionsBot

   on Apr 5, 2024 – with GitHub Actions

   Contributor

   More actions

   ⚠️COMMENT VISIBILITY WARNING⚠️

   This issue is now closed. Please be mindful that future comments are hard for our team to see.

   If you need more assistance, please either tag a team member or open a new issue that references this one.

   If you wish to keep having a conversation with other community members under this issue feel free to do so.
9. github-actions

   added

   pending-releaseFix or implementation already in dev waiting to be releasedFix or implementation already in dev waiting to be released

   on Apr 5, 2024
10. heitorlessa

    moved this from Coming soon to Shipped in Powertools for AWS Lambda (Python)on Apr 5, 2024
11. heitorlessa

    reopened this on Apr 5, 2024
12. github-project-automation

    moved this from Shipped to Pending review in Powertools for AWS Lambda (Python)on Apr 5, 2024
13. heitorlessa commented on Apr 5, 2024

    

    heitorlessa

    on Apr 5, 2024

    ContributorAuthor

    More actions

    Reopening as there's some fixes to port from another branch, and to share lessons learned in this.
14. heitorlessa commented on Apr 5, 2024

    

    heitorlessa

    on Apr 5, 2024

    ContributorAuthor

    More actions

    Main lesson learned is that when using cross-repo workflows that use local scripts, we must change the checkout in the target workflow to explicitly checkout itself.

    What do I mean by that?

    Take the following job in mind

    jobs:
        call-workflow-passing-data:
            permissions:
                contents: read
                pull-requests: read
                issues: write  # create monthly roadmap report
            uses: aws-powertools/actions/.github/workflows/monthly_roadmap_reminder.yml@main
            secrets:
                token: ${{ secrets.GITHUB_TOKEN }}

    There are two implicit designs that aren't easy to understand at first and docs don't call that out:

    1. aws-powertools/actions is where the workflow is
    2. monthly_roadmap_reminder.yml is the workflow name
    3. The workflow runs in this repository

    With that in mind, the target workflow naturally would try to do a code checkout as its first step. However, that code checkout will checkout this repository (Python source code), not the shared actions we want.

    For this to work, the target workflow owned by aws-powertools/actions must explicitly pass which repository it will checkout code -- it can't be via ${{github.repo}} because it would resolve to powertools-lambda-python.

    jobs:
      build:
        runs-on: ubuntu-latest
        steps:
          - uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633  # v4.1.2
            with:
                # NOTE Since it's called from another repository
                # we must checkout the repository where the github-script is (aws-powertools/actions)
                # otherwise the caller check out their own repository code (e.g., Python/TS), where the github-scripts aren't available
                repository: aws-powertools/actions

    A nicer benefit of this is that we don't need to control from the target who can call it and try to abuse creating GitHub issues in another place, because it's the caller repository that runs the workflow (it's not a fire-n-forget).

    👍React with 👍1Reacted by Ruben Fonseca
15. github-actions commented on Apr 18, 2024

    

    github-actionsBot

    on Apr 18, 2024 – with GitHub Actions

    Contributor

    More actions

    This is now released under 2.37.0 version!
16. github-actions

    closed this as completedon Apr 18, 2024
17. github-actions

    removed

    pending-releaseFix or implementation already in dev waiting to be releasedFix or implementation already in dev waiting to be released

    on Apr 18, 2024
18. github-project-automation

    moved this from Pending review to Coming soon in Powertools for AWS Lambda (Python)on Apr 18, 2024
19. leandrodamascena

    moved this from Coming soon to Shipped in Powertools for AWS Lambda (Python)on Apr 19, 2024
20. github-actions

    added

    pending-releaseFix or implementation already in dev waiting to be releasedFix or implementation already in dev waiting to be released

    on May 2, 2024
21. github-actions commented on May 17, 2024

    

    github-actionsBot

    on May 17, 2024 – with GitHub Actions

    Contributor

    More actions

    This is now released under 2.38.0 version!
22. github-actions

    removed

    pending-releaseFix or implementation already in dev waiting to be releasedFix or implementation already in dev waiting to be released

    on May 17, 2024