Skip to content

R2 overwrites parent method #115

Open

Description

@JB-Wolf

R2 Overwrites Valve method

Problem

set_position and get_position are redefined

Effect

  • Maintainability harder
  • affects behaviour uniformity

Solution

Device should just expose rule in _change_position (only device_component specific code part). Device level method is selected via hw_device attribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions