This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Repository navigation
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
npm install fails with Node 12 #75
Description
Description
npm install with Node 12 fails
Steps to Reproduce
- clone the repo
- make sure you are using Node 12.x
- npm install
Expected behavior:
Installs just fine
Actual behavior:
../src/bindings/marker-index-wrapper.cc:350:43: error: no matching function for call to ‘v8::Integer::NumberValue()’
350 | max_count = js_max_count->NumberValue();
| ^
Is the last error but there are previous too.
Reproduces how often:
Always
Versions
Current master
Activity
Arcanemagus commentedon Jun 27, 2019
Work is currently underway on this in #72.
akurtakov commentedon Jul 29, 2019
So next thing is - when is release with this patch planned so it can be freely used on Node 12?
akurtakov commentedon Aug 26, 2019
Please cut out new release.
smackesey commentedon Oct 13, 2020
Is this library supposed to be compatible with newer Node versions? I am trying to do some contributions for node-tree-sitter but its dependency makes my
npm installfail. I'm on Node 14.DeeDeeG commentedon Dec 2, 2020
This should be fixed now. CI is testing with 12.14.1 and passing (if you disregard CircleCI, which isn't running).
aminya commentedon Dec 5, 2020
This should be closed. It is already fixed.