Repository navigation
Conversation
joshi-07
requested review from
AayushSaini101,
asyncapi-bot-eve,
magicmatatjahu and
princerajpoot20
as code owners
October 21, 2026 07:49
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
🦋 Changeset detectedLatest commit: a9837b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Resolves #876
Description
According to the AsyncAPI 3.0.0 Specification (Section 4.3.4, Operation Reply Object):
Previously, the parser did not validate this condition, allowing documents with dynamic reply addresses (e.g.
reply.address.location) pointing to channels with concrete addresses (e.g.address: 'user/signedup') to pass validation silently.Changes
operationReplyAddressSpectral function underpackages/parser/src/ruleset/v3/functions/operationReplyAddress.tsthat resolves local component reference chains (resolveLocalReference) and asserts that ifreply.addressis specified, the associated channel'saddressis eithernullor omitted (undefined).asyncapi3-operation-reply-addressinv3CoreRuleset(packages/parser/src/ruleset/v3/ruleset.ts) matching$.operations.*.replyand$.components.operations.*.reply.packages/parser/test/ruleset/rules/v3/asyncapi3-operation-reply-address.spec.tscovering root channels, component reference chains, inline channel objects, and positive/negative scenarios.userSignupReplyintest/parse.spec.tsto useaddress: nullso that test fixtures remain compliant with the v3 specification.@asyncapi/parser(patch).Verification
npm run lint: passed with 0 warningsnpm run build: passed across all 4 packagesnpm run parser:test:unit: all 151 test suites and 2,538 tests passed with 100% coverage onoperationReplyAddress.ts