Repository navigation
fix: validate channel address when parameters are defined - #1123
abhi-03-kh wants to merge 3 commits into
Conversation
🦋 Changeset detectedLatest commit: e0fd14a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
@fmvilas @magicmatatjahu , any feedback on this when you have time? |
|
|
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
Description
This PR adds a validation rule to ensure that if a Channel Object has
parametersdefined, theaddressfield must not be null.Fixes #875
Changes
channel-parameters-require-addressrule tov3/ruleset.ts.channel-parameters.spec.tsto verify the rule catches invalid documents.Verification
npm test -- test/ruleset/rules/v3/channel-parameters.spec.ts