Repository navigation
Do not record cpu frame on non perf samples - #1651
Merged
Merged
Conversation
Member
|
Makes sense. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While analyzing some async-profiler JFRs on some custom tests, I noticed that it's possible for the profiler to incorrectly record an invalid CPU frame when no such capabilities exist for the sample type
This happens when user runs
event=cpu-clock,record-cpu,wall,file=profile.jfrWhen a wall sample is collected, the profiler will incorrectly assume it has a valid CPU number but that is wrong, as such a check was added to only add the CPU frame for perf samples
This is relevant for all non perf profiling engines when run in parallel with perf
Related issues
N/A
Motivation and context
Do not record invalid CPU information in the collected stacks of non perf samples
How has this been tested?
A new test was added
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.