Repository navigation
Use PEP 508 URLs for build backend requirements - #2754
Closed
charliermarsh wants to merge 1 commit into
Closed
charliermarsh wants to merge 1 commit into
charliermarsh wants to merge 1 commit into
Conversation
This was referenced Oct 14, 2026
Merging this PR will not alter performance
|
charliermarsh
marked this pull request as ready for review
October 15, 2026 00:09
|
Promoted to #22577. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We parse
build-system.requiresas PEP 508 requirements in the build backend, reserving distribution-URL classification foruv's direct-build validation. The frontend supplies the build requirements before invoking the backend, so the backend does not need Git parsing or archive-extension inference for those URLs.This intentionally accepts some build-system URLs that the backend previously rejected, such as
uv_build @ hg+https://example.com/uv-buildor an archive download endpoint without a filename extension. Requirement syntax and project dependency parsing remain unchanged. Direct builds retain the richer URL parser and its existing errors.On Linux x86_64 with Rust 1.99.0 and the stripped
minimal-sizeprofile,uv-builddecreases from 3,075,808 to 3,029,232 bytes (46,576 bytes, 1.51%) againstmainate37c1f0c6.All 68 backend tests, strict clippy, and formatting pass. A regression test exercises successful backend metadata generation and rejection by direct-build validation for the same Mercurial URL. Comparisons across 180 URL cases, 756 marker cases, and the CLI/archive corpus found only the intended build-system URL validation changes; previously successful builds produce identical output.
This absorbs the standalone-binary size benefit of #2753, so their savings should not be added together.