Skip to content

Show the offending URL in Python mirror errors - #2495

Closed
zaniebot wants to merge 1 commit into
mainfrom
zb/python-mirror-error-url
Closed

zaniebot wants to merge 1 commit into
mainfrom
zb/python-mirror-error-url

Conversation

@zaniebot

@zaniebot zaniebot commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator

When a Python download URL does not match the upstream format expected by a custom mirror, the error repeats the mirror environment variable instead of showing the offending URL. Display the URL in that diagnostic and store it as a DisplaySafeUrl so passwords and sensitive query parameters are redacted. Malformed source URLs use the existing InvalidUrl error.

@zaniebot
zaniebot deployed to automations October 8, 2026 15:04 — with GitHub Actions Active
@astral-automations-bot astral-automations-bot Bot added area:error-messages Messaging when something goes wrong bug Something isn't working labels Oct 8, 2026
@codspeed

codspeed Bot commented Oct 8, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 54 untouched benchmarks
⏩ 35 skipped benchmarks1


Comparing zb/python-mirror-error-url (f42ee29) with main (cea939e)

Open in CodSpeed

Footnotes

  1. 35 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@zanieb
zanieb marked this pull request as ready for review October 8, 2026 15:58
@astral-automations-bot

Copy link
Copy Markdown

Promoted to #22364.

This branch was successfully deployed

1 active deployment
automations — f42ee29d Deployed Oct 8, 2026 by zaniebot via review-code-quality / code quality review #8343
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:error-messages Messaging when something goes wrong bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant