[zaniebot]

Passwords ending in spaces or tabs fail authentication through the subprocess keyring because trim_end() removes those characters along with the newline printed by keyring get. Strip only one LF or CRLF terminator so trailing password whitespace reaches the server.

[astral-automations-bot]

Promoted to #22284.

[codspeed]

Merging this PR will improve performance by ×9

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 11 improved benchmarks
✅ 43 untouched benchmarks
⏩ 35 skipped benchmarks¹

Performance Changes

	Mode	Benchmark	BASE	HEAD	Efficiency
⚡	WallTime	unzip_wheel_many_files	371 ms	12.3 ms	×30
⚡	WallTime	install_wheel_many_files	385 ms	14.3 ms	×27
⚡	WallTime	prepare_wheel_many_files	383.4 ms	15.1 ms	×25
⚡	WallTime	unpack_sdist_many_files	317.2 ms	37 ms	×8.6
⚡	WallTime	resolve_warm_jupyter_universal	87.6 ms	11.9 ms	×7.4
⚡	WallTime	resolve_warm_jupyter	17.4 ms	2.5 ms	×6.9
⚡	WallTime	discover_workspace_from_all_members_with_excludes	52.7 ms	8.4 ms	×6.2
⚡	WallTime	discover_workspace_from_all_members	50.5 ms	8.2 ms	×6.2
⚡	WallTime	run_python_version_synthetic_workspace	268.4 ms	43.8 ms	×6.1
⚡	WallTime	resolve_warm_airflow	233.2 ms	42.3 ms	×5.5
⚡	WallTime	hash_sha256	1,165.6 µs	417.7 µs	×2.8

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.

---

_{Comparing zb/bughunt200/114-subprocess-keyring-whitespace (c0c99cd) with main (b7c8c62)²}

Footnotes

1. 35 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

2. No successful run was found on main (27b9edf) during the generation of this report, so b7c8c62 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩