Skip to content

Allow UV_OFFLINE=false to override configuration - #145

Closed
zaniebot wants to merge 1 commit into
mainfrom
zb/bughunt200/177-offline-env-false
Closed

zaniebot wants to merge 1 commit into
mainfrom
zb/bughunt200/177-offline-env-false

Conversation

@zaniebot

@zaniebot zaniebot commented Jul 16, 2026 •

Copy link
Copy Markdown
Collaborator

NetworkSettings::resolve honors UV_OFFLINE only when it is true, so UV_OFFLINE=0 cannot override configured offline = true despite CLI/environment/config precedence. Preserve the environment's explicit false value.

@zaniebot zaniebot changed the title Allow UV_OFFLINE=false to override configuration Allow UV_OFFLINE=false to override configuration Jul 16, 2026
@zaniebot zaniebot added priority:2 Important: bounded correctness, release reliability, committed work, or proven performance gains. size:1 Small: one localized behavior with straightforward tests or documentation checks. bug Something isn't working risk:3 Credible risk of meaningful incorrect behavior or regression; bounded or recoverable. labels Sep 9, 2026
@zanieb
zanieb marked this pull request as ready for review October 7, 2026 17:20
@astral-automations-bot

Copy link
Copy Markdown

Promoted to #22283.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working priority:2 Important: bounded correctness, release reliability, committed work, or proven performance gains. risk:3 Credible risk of meaningful incorrect behavior or regression; bounded or recoverable. size:1 Small: one localized behavior with straightforward tests or documentation checks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants