Repository navigation
Clarify API/documentation #9
Description
Continuing discussion at #6 (comment)
The problem: By construing the home parameter as my actual $HOME directory, I accidentally overwrote the .zshenv file in it because completest creates a file of such a name there unconditionally. I think it’s a papercut that it would be nice to clarify.
The suggested solution:
- Deprecate/remove
new()because more specific names tend to be more descriptive (IMO, of course). - Rename “home” to “workdir” because it can be confused with an actual home directory and result in overwritten configuration files.
- Add a new constructor
with_temp_workdir(bin_root)that creates a temporary workdir automatically. - Probably also rename
bin_rootto something likeshell_binary_dir_path.
EDIT: Clarify the problem.
Activity
epage commentedon Jul 31, 2023
Except we are treating it as the home directory.
btw this is a list of proposed solutions without a description of the problem. In the future, please focus on the problem though you are welcome to provide suggested solutions. We just need to keep in mind the context of what we are working in and what the actual goal is.
adaszko commentedon Aug 1, 2023
The problem is that I accidentally obliterated my .zshenv. I thought that was clear from the previous issue:
#6 (comment):
In any case, I updated the issue description.