Repository navigation
Conversation
The "Last Touched By" column has no tablesorter parser, so it fell back
to the default text sorter, which compares the whole cell text: the
maintainer name followed by a humanized duration such as "(1 week ago)".
For a single maintainer that yields the nonsense order "1 week ago",
"2 days ago", "4 days ago".
Tag the cell with its epoch timestamp and reuse the existing epochdate
parser, as the signoffs table already does. Packages nobody touched yet
keep no timestamp and sort first, as they did before.
The epochdate parser called `$(cell).attr('class')` without allowing for
a cell that has no class attribute at all. That is now reachable from
untouched packages in a todo list and aborted the sort with a TypeError,
so fall back to an empty string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Last Touched By" column has no custom tablesorter parser, so it fell back to the default text sorter which compares the whole cell text: the maintainer name followed by a humanized duration such as "(1 week ago)". That put "1 week ago" before "4 days ago".
Tag the cell with the epoch timestamp and reuse the existing epochdate parser, as the signoffs table already does.