Repository navigation
fix(auth): scopeBy fields with other names take the caller's tenant - #167
Merged
Merged
Conversation
ScopeGuard and @CrudAuth looked the tenant up under the scopeBy field's own name, which the auth guards only set for workspaceId and organizationId. An imported schema scoped on orgId refused every request. With auth configured, both now fall back to the matching auth context field, then the auth tenant. The auth smoke covers a Note entity scoped on orgId.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while writing the Supabase migration guide. Imported schemas keep source column names such as
orgId, andscopeBy: "orgId"then refused every request under 0.45.x. The scope guard and@CrudAuthlooked uprequest.orgId, which no auth guard sets. With auth configured they now fall back torequest.auth[field], thenrequest.auth.workspaceId.Tests: the auth smoke adds a
Noteentity scoped onorgId. A create stores the caller's tenant, and the other tenant can't read or list it. All three languages pass locally, and 515 unit tests pass.