Repository navigation
Conversation
edavidj
reviewed
Jun 19, 2020
| return label, annotations | ||
| } | ||
| func createRuntimeComponent(n, ns string, spec appstacksv1beta1.RuntimeComponentSpec) *appstacksv1beta1.RuntimeComponent { | ||
| func createRuntimeComponent(n, ns string, spec appstacksv1beta1.RuntimeComponentSpec, labels map[string]string, annotations map[string]string) *appstacksv1beta1.RuntimeComponent { |
Contributor
There was a problem hiding this comment.
It might be cleaner to have this take a metav1.ObjectMeta as a parameter instead of four separate params.
edavidj
approved these changes
Jun 19, 2020
edavidj
left a comment
edavidj
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just left one comment on the createRuntimeComponent function 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?: