Skip to content

import command doesn't throw error for invalid json #175

Open

Description

@lakhansamani

Currently, abc doesn't throw an error when we have an invalid JSON file, rather it succeeds with 0 records inserted.

How to replicate

  • Create an invalid JSON file. Here file has extra ,
echo '[
  {
    "name": "jame",
    "email": "jame@yopmail.com",
  }
]' > test1.json
  • Try abc command
    abc import --src_type=json --src_uri=test1.json --log.level=debug http://admin:admin@localhost:9200/test

  • abc version used here: 1.0.0 Preview Release 2

Expected output

Command should throw an error with correct exit status, if the command fails

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions