This repository was archived by the owner on Feb 26, 2026. It is now read-only.
Repository navigation
Upgrades htmlparser2 to new major version ^8.0.0. (#1) - #567
Closed
kedarchandrayan wants to merge 1 commit into
Closed
kedarchandrayan wants to merge 1 commit into
kedarchandrayan wants to merge 1 commit into
Conversation
boutell
suggested changes
Sep 6, 2022
Member
There was a problem hiding this comment.
Thank you for contributing. Some concerns:
- Did htmlparser2 change their nodejs version requirements? Did they change their options in a backwards-incompatible way? Either would require a major version bump for sanitize-html.
- This PR changes many unrelated things. Please submit a clean PR just for this change and any required changes to support it.
- This PR removes a unit test without explanation. Please provide an explanation for the removal and why it is safe to skip that test.
Contributor
Author
|
Closing this PR in favour of the clean new PR #573 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #565
What are the specific steps to test this change?
All existing behavior should remain same.
What kind of change does this PR introduce?
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: