Repository navigation
fix(licensing, v1.2): take the Iris example dataset from scikit-learn instead of UCI - #9009
Draft
github-actions[bot] wants to merge 1 commit into
Draft
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…ad of UCI (#9000) ### What changes were proposed in this PR? The single-node examples ship `Iris.csv` in both the source release and the docker-compose bundle, and `LICENSE` records it as CC BY 4.0 from the UCI repository (#8803). ASF policy allows CC BY works only in binary form ("only include them in binary form", https://www.apache.org/legal/resolved.html), so the file can't be in a source release under that licence. This takes the dataset from the copy scikit-learn distributes under the BSD 3-Clause License instead. The CSV keeps its columns, row order and species names, so the example workflow is unaffected. Only rows 35 and 38 change: they are the two known transcription errors in the UCI copy, which scikit-learn's copy corrects to Fisher's published values. The `LICENSE` entries (root and `bin/single-node/`) move to BSD 3-Clause, the compose bundle ships the BSD 3-Clause text instead of CC BY 4.0, the now-unused `licenses/LICENSE-CC-BY-4.0.txt` is removed, and the dataset description names the new source. This conflicts with #8997 in `LICENSE`, since both add the BSD 3-Clause section; whichever lands second merges the two entries. ### Any related issues, documentation, discussions? Follows up #8803. ### How was this PR tested? Checked that every row of the new `Iris.csv` matches scikit-learn 1.7.2's `iris.csv`. Ran the bundle's `git archive` export step against this commit to confirm it picks up the BSD 3-Clause text, and checked that the new description still makes valid JSON in `load-examples.sh`, which inserts it unescaped. ### Was this PR authored or co-authored using generative AI tooling? (backported from commit 707849a) Generated-by: Claude Code (claude-opus-5-5)
Contributor
Author
|
The cherry-pick conflicted and was committed with conflict markers. Resolve the conflicts on this branch, then mark this PR ready for review. Conflicting files:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Automated backport of #9000 to
release/v1.2.Source: 707849a · automation run
Any related issues, documentation, discussions?
Backport of #9000.
How was this PR tested?
Release-branch CI runs on this branch once the conflicts are resolved and this PR is marked ready for review.
Was this PR authored or co-authored using generative AI tooling?
No.