Repository navigation
docs: record registry core/implementation decoupling in release notes (#7585) - #7642
Merged
Merged
Conversation
…apache#7585) PR apache#7578 removed the five registry implementation dependencies from shenyu-registry-core, which is a runtime-visible behavior change for downstream users rather than a code-organization-only refactor: an application on shenyu-registry-core (or on shenyu-sdk-core / shenyu-sdk-feign, which now sit on shenyu-registry-api) no longer gets the implementations transitively, so an upgrade without an explicit provider declaration fails at startup. The registerType-with-no-provider case also changes from silent to throwing. Adds one entry under Unreleased / Behavior Changes covering that, the new public loadRepository(String) surface, and the compatibility story for shenyu-admin and shenyu-spring-boot-starter-registry. Migration guidance is delegated to shenyu-registry/README.md, added by apache#7578. Documentation only. Fixes apache#7585
Aias00
approved these changes
Oct 16, 2026
Aias00
left a comment
Contributor
There was a problem hiding this comment.
Review: Record registry core/implementation decoupling in release notes (#7585)
Docs-only change that accurately documents the shenyu-registry-core decoupling (#7578).
What's good
- The release note clearly explains the behavioral change:
shenyu-registry-coreno longer transitively provides registry implementations, so applications must declare the provider for theirregisterTypeexplicitly. The XML snippet, the improvedIllegalArgumentExceptionmessage (naming the missing artifact + available SPI types), the unaffectedshenyu-spring-boot-starter-registryaggregate, and the Apollo note are all correct and helpful for users upgrading.
Conclusion
Accurate, well-written documentation. Approving. The only red CI jobs are the usual infra e2e/compose runs — unrelated to a docs change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7585
Modifications
Adds one entry under
## Unreleased→### Behavior ChangesinRELEASE-NOTES.md, covering the behavior change from #7578 (refactor(registry): decouple core from registry implementations, merged asa7d80b7).Documentation only — no Java, POM, or configuration change.
What the entry records
shenyu-registry-coreno longer transitively provides registry implementations; applications depending on it (or onshenyu-sdk-core/shenyu-sdk-feign) must declare the provider matching their configuredregisterTypeexplicitly, with an example<dependency>block.registerTypehas no SPI provider on the classpath is now anIllegalArgumentExceptionnaming the missing artifact, replacing the previousExtensionLoader.getJoinfailure.ShenyuInstanceRegisterRepositoryFactory#loadRepository(String)is public API, andAbstractDiscoveryProcessor#createDiscoveryresolves its repository through it.shenyu-adminandshenyu-spring-boot-starter-registryre-declare all five providers, so existing users of the compatibility starter are unaffected. Apollo was never part of that aggregate.shenyu-registry/README.md, added by [ISSUE #7311] Decouple registry core from implementations. #7578.Scope
Only the
### Behavior Changessection is touched. The existing### API Changesentries (MemorySafeLRUMapdeprecation,DiscoveryUpstreamDataSubscriber#unSubscribesignature replacement) look unrelated to #7578, so I left them as they are — happy to move the entry elsewhere if that's the convention you prefer.Verifying this change
git diff --stat→1 file changed, +25 insertions(-). No build is required for a documentation-only change.