Repository navigation
build: remove misspelled log4j-1.2-api property and obsolete zookeeper log4j exclusion (#7609) - #7618
Merged
Conversation
…r log4j exclusion (apache#7609) - <log4j-1.2-api.vetsion> has no references anywhere in the repository (neither the misspelled nor the correctly spelled form), so it is removed rather than renamed. - The log4j:log4j exclusion under org.apache.zookeeper:zookeeper is obsolete with zookeeper 3.9.5: its POM declares no log4j dependency, and a dependency:tree run with the exclusion removed shows zero log4j hits. Fixes apache#7609
Aias00
approved these changes
Oct 15, 2026
Aias00
left a comment
Aias00
left a comment
Contributor
There was a problem hiding this comment.
Review: build: remove misspelled log4j-1.2-api property and obsolete zookeeper log4j exclusion (#7609)
Exactly the cleanup proposed in #7609. The misspelled log4j-1.2-api.vetsion property is dead (nothing references it, and the correct key is log4j-1.2-api.version), and the log4j:log4j exclusion on zookeeper is obsolete: the project uses zookeeper.version 3.9.5, which depends on log4j-1.2-api (the Log4j2 bridge) rather than the legacy log4j:log4j 1.x artifact, so removing the exclusion does not reintroduce a vulnerable 1.x dependency.
Trivial, safe, correct. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7609
What is the purpose of the change
Build hygiene cleanup in the root POM, as requested in the issue:
<log4j-1.2-api.vetsion>— it has no references anywhere in the repository (neither the misspelled nor the correctly spelled form), so it is removed rather than renamed.log4j:log4jexclusion under theorg.apache.zookeeper:zookeeperentry in<dependencyManagement>— obsolete with zookeeper 3.9.5.Brief changelog
pom.xml: drop one property line and the zookeeperlog4j:log4jexclusion block.Verifying this change
grep -rn "log4j-1.2-api" --include="*.xml" .→ only the removed definition line existed; no${...}references before or after the change, so no dangling references.org.apache.zookeeper:zookeeper:3.9.5declares no log4j dependency../mvnw -pl shenyu-infra/shenyu-infra-zookeeper dependency:tree -Dincludes=log4j:log4jreturns zero hits while zookeeper 3.9.5 still resolves (transitively via curator)../mvnw -B validate -pl shenyu-common,shenyu-spi,shenyu-registry/shenyu-registry-api,shenyu-infra/shenyu-infra-common -amSUCCESS; and./mvnw -B install -DskipTests -Dmaven.javadoc.skip=true -pl shenyu-registry/shenyu-registry-api,shenyu-registry/shenyu-registry-zookeeper -am— 9/9 modules SUCCESS (BUILD SUCCESS in 21.9s, incl.shenyu-infra-zookeeperwhich resolves zookeeper 3.9.5 transitively via curator). Full reactor build runs in CI.Checklist