Skip to content

[type:fix] fix MemorySafeWindowTinyLFUMap memory leak error - #4524

Merged
loongs-zhang merged 5 commits into
apache:masterfrom
xuyicheng1995:dev
Apr 2, 2023
Merged

loongs-zhang merged 5 commits into
apache:masterfrom
xuyicheng1995:dev

Conversation

@xuyicheng1995

@xuyicheng1995 xuyicheng1995 commented Apr 1, 2023 •

Copy link
Copy Markdown
Contributor

[ISSUE #4475] fix MemorySafeWindowTinyLFUMap memory leak error fix #4475

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@xuyicheng1995

Copy link
Copy Markdown
Contributor Author

@moremind please help me review the code

@moremind
moremind requested a review from loongs-zhang April 1, 2023 14:48
@codecov-commenter

codecov-commenter commented Apr 2, 2023 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.44%. Comparing base (09b236e) to head (4282651).
⚠️ Report is 929 commits behind head on master.

Files with missing lines Patch % Lines
...henyu/common/cache/MemorySafeWindowTinyLFUMap.java 62.50% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4524      +/-   ##
============================================
+ Coverage     68.37%   68.44%   +0.06%     
- Complexity     7612     7627      +15     
============================================
  Files          1028     1028              
  Lines         29433    29440       +7     
  Branches       2665     2666       +1     
============================================
+ Hits          20125    20150      +25     
+ Misses         7711     7694      -17     
+ Partials       1597     1596       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@loongs-zhang loongs-zhang added the type: bug Something isn't working label Apr 2, 2023
@loongs-zhang loongs-zhang added this to the 2.6.0 milestone Apr 2, 2023
@loongs-zhang
loongs-zhang merged commit 4491cb8 into apache:master Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] <may MemorySafeWindowTinyLFUMap cause a memory leak>

3 participants