Repository navigation
HDDS-17025. Container push with a negative size reserves a negative amount on the receiving volume that is never released - #11565
Open
Gargi-jais11 wants to merge 1 commit into
Open
Gargi-jais11 wants to merge 1 commit into
Gargi-jais11 wants to merge 1 commit into
Conversation
smengcl
approved these changes
Oct 16, 2026
smengcl
left a comment
smengcl
left a comment
Contributor
There was a problem hiding this comment.
Thanks @Gargi-jais11 . lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When a container push includes a negative size (from a source whose bytesUsed counter has drifted), the receiving datanode reserved 2 * size, which is negative. That lowered the volume’s committed bytes and was never released because release only runs when
spaceToReserve > 0. SCM and local volume selection would have inflated free space.Fixed:
ContainerImporter.getSpaceToReservenow treats a negative size, or one where required replication space would overflow, like a missing size and reserves the default replication space (2 * ozone.scm.container.size) instead.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-17025
How was this patch tested?
Confirmed the new test suggested in the jira
testInvalidSizeReservesDefaultSpacefailed without the fix and after fix it passes.Generated with Specula (Claude Opus 5.5).