NIFI-15857 Added Dismiss button to overlapping connections banner

[anshuksi282-ksolves]

Summary

NIFI-15857

The overlapping connections banner added in NIFI-15654 is always displayed while overlapping connections exist, which is a nuisance for flows where overlapping connections are intentional.

This adds a Dismiss button to the banner. Dismissal is kept in component state only, in line with the other dismissible
banners in the UI, and the banner is displayed again when the set of overlapping connections changes.

Tests in overlapping-connections-banner.component.spec.ts cover hiding the banner on dismiss, showing it again when the overlapping connections change, and keeping it hidden when the same overlapping connections are re-evaluated.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

• Apache NiFi Jira issue created

Pull Request Tracking

• Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
• Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000
• Pull request contains commits signed with a registered key indicating Verified status

Pull Request Formatting

• Pull Request based on current revision of the main branch
• Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

• Build completed using ./mvnw clean install -P contrib-check
  • JDK 21
  • JDK 25

The frontend was verified with nx test nifi for the banner and canvas specs, nx lint nifi and Prettier. NiFi was
also assembled with ./mvnw install -DskipTests -pl nifi-assembly -am on JDK 21 and started locally.

Licensing

• New dependencies are compatible with the Apache License 2.0 according to the License Policy
• New dependencies are documented in applicable LICENSE and NOTICE files

No new dependencies were added.

Documentation

• Documentation formatting appears as expected in rendered files

No documentation files were changed.

[anshuksi282-ksolves]

Hi @pvillard31 @exceptionfactory,

Could you please take a look at this PR whenever you get a chance? Or if you think someone else would be the right reviewer for this, please let me know or tag them here.

Thank you!

[mcgilman]

The overlapping connections banner added in NIFI-15654 is always displayed while overlapping connections exist, which is a nuisance for flows where overlapping connections are intentional.

@anshuksi282-ksolves Why is intentionally overlapping connections desirable? IIRC the overlapping logic only considers connections overlapping if they have no additional bend points. So connections are overlapping when they have the same source and destination. In this case, the connection label is placed in the middle of both connections right on top of each other. This blocks the label making it impossible to see the queue details of the label underneath. If you truly want the connections right on top of each other, you could always add a bend point to one of the connections. This should allow the connections to not be considered overlapping and additionally allows you to not miss the connection label.

[anshuksi282-ksolves]

The overlapping connections banner added in NIFI-15654 is always displayed while overlapping connections exist, which is a nuisance for flows where overlapping connections are intentional.

@anshuksi282-ksolves Why is intentionally overlapping connections desirable? IIRC the overlapping logic only considers connections overlapping if they have no additional bend points. So connections are overlapping when they have the same source and destination. In this case, the connection label is placed in the middle of both connections right on top of each other. This blocks the label making it impossible to see the queue details of the label underneath. If you truly want the connections right on top of each other, you could always add a bend point to one of the connections. This should allow the connections to not be considered overlapping and additionally allows you to not miss the connection label.

Thanks for the review. The use case in the description comes from the reporter of NIFI-15857, not from me, and
I should have worded the summary as the reporter's request rather than as a given.

I agree with your point: overlapping connections hide the label and queue details of the one underneath, and a
bend point separates them and clears the banner, which is also what the banner text suggests.

I'll leave it to you and the reporter to decide whether a Dismiss button is still wanted. If the preferred
resolution is the bend point workaround, I'm happy to close this PR and the Jira issue can be resolved
accordingly.

[mcgilman]

I'll leave it to you and the reporter to decide whether a Dismiss button is still wanted. If the preferred resolution is the bend point workaround, I'm happy to close this PR and the Jira issue can be resolved accordingly.

I've left a comment on the JIRA for the original reporter to better understand the use case.