Repository navigation
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
normalize/rep:normalizequery function, similar to the same Jackrabbit function, useful for sorting and filtering on non-ASCII strings.The implementation is inspired by lower / upper functions and is based on the Lucene's ASCIIFoldingFilter. However, in Jackrabbit, there was a direct dependency on Lucene, so we could have a direct reference to ASCIIFoldingFilter. Here in Oak, there's no such dependency at oak-core level, so I had to copy the class. Don't hesitate to correct me if I'm wrong.
Please note that it's my very first Oak PR, and that I didn't exercise my Jackrabbit committership in years, so please tell me everything wrong :)