Repository navigation
Core: Reference ContentScanTask::length in RewriteGroupBase - #18772
Open
slachiewicz wants to merge 1 commit into
Open
slachiewicz wants to merge 1 commit into
slachiewicz wants to merge 1 commit into
Conversation
Generated-by: Claude Code
slachiewicz
marked this pull request as ready for review
November 3, 2026 16:16
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RewriteGroupBase.inputFilesSizeInBytesusesT::length, a method reference qualified by a typeparameter. Error Prone 2.47 and later report it as
TypeParameterQualifier(google/error-prone#5766),which blocks moving the build to a newer Error Prone.
ContentScanTask::length, the bound ofT,is the same call.
Test plan:
:iceberg-corecompiles with Error Prone; checkstyle, spotless and revapi pass;TestBinPackRewriteFilePlanner (27), TestBinPackRewritePositionDeletePlanner (13) and
TestSizeBasedFileRewritePlanner (3) pass on JDK 21.