[Feature] build manager image in build-images.sh #278

Activity

1. Radeity

   added

   featureNew featureNew feature

   on Oct 31, 2023
2. Radeity

   changed the title [-][Feature] push manager image in build-images.sh[/-] [+][Feature] build manager image in build-images.sh[/+] on Oct 31, 2023
3. Radeity commented on Oct 31, 2023

   

   Radeity

   on Oct 31, 2023

   MemberAuthor

   More actions

   cc @coderzc
4. imbajin commented on Oct 31, 2023

   

   imbajin

   on Oct 31, 2023

   Member

   More actions

   Feature Description (功能描述)

   Now, we have manager container introduced by #259. Thus, we have to modify image building script.

   BTW, may I ask, currently, how to trigger new image building and uploading in HugeGraphComputer? It seems like publish_images.yml in .workflow is deprecated?

   due to lack some "GITHUB_TOKEN" permission here, so transfer to
   https://github.com/hugegraph/actions/blob/master/.github/workflows/publish_computer_image.yml

   so as other similar CIs
5. Radeity commented on Oct 31, 2023

   

   Radeity

   on Oct 31, 2023

   Last edited by Radeity

   MemberAuthor

   More actions

   Hi @imbajin , get it, thanks.

   However, may I ask why we comment the cron schedule in publish_computer_image.yml? If we comment these, we should let user know how to build the latest images by themselves, maybe have to maintain the latest script(with new image manager) in this repo, either, and declare in our doc.
   https://github.com/hugegraph/actions/blob/4eb9db3d644408df8f47558ecf151b510a1ffd24/.github/workflows/publish_computer_image.yml#L3-L5
6. imbajin commented on Nov 1, 2023

   

   imbajin

   on Nov 1, 2023

   Last edited by imbajin

   Member

   More actions

   Hi @imbajin , get it, thanks.

   However, may I ask why we comment the cron schedule in publish_computer_image.yml? If we comment these, we should let user know how to build the latest images by themselves, maybe have to maintain the latest script(with new image manager) in this repo, either, and declare in our doc. hugegraph/actions@4eb9db3/.github/workflows/publish_computer_image.yml#L3-L5

   Good catch & thanks for the reminder (Context: computer has not been updated for a period of time before, and it is unreasonable to keep updating the image on a regular crontab. We should use a hook mechanism that updates when there is a new commit)

   @Radeity could u follow the PR (hugegraph/actions#2) to update computer image with hook m* when free? (also divide it into 2 ci action for release/stable version)

   If not free these days, could assign to @aroundabout & comment here

   👀React with 👀1Reacted by Dandelion