Repository navigation
Add SECURITY.md - #781
Open
leerho wants to merge 2 commits into
Open
Add SECURITY.md#781leerho wants to merge 2 commits into
leerho wants to merge 2 commits into
Conversation
Describes how to report vulnerabilities privately and the security model, adapted from datasketches-cpp for Java: deserialization of arbitrary input must be rejected with a SketchesException and must not hang, allocate based on inconsistent or out-of-limit declared sizes, or return a sketch that fails later. A caller-provided MemorySegment larger than the sketch needs is supported. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…lure rule Malformed input may be rejected with any RuntimeException, not only a SketchesException, since standard Java exceptions are often more descriptive. Throwing an Error is not acceptable. A sketch that accepts a corrupt image is a vulnerability only if a later operation hangs or exhausts memory; a later runtime exception is an ordinary bug. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
proost
approved these changes
Oct 26, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
SECURITY.md, adapted from the one in datasketches-cpp (apache/datasketches-cpp#545), so both libraries make the same commitments.It covers:
heapify(),wrap(),writableWrap(),getInstance()anddeserialize()must be safe on arbitrary input. Malformed input must be rejected with aRuntimeException: usually aSketchesArgumentException, but standard Java runtime exceptions are also acceptable. Throwing anError(such asOutOfMemoryError) is not.MemorySegmentlarger than the sketch needs, so a direct sketch can grow in place, is allowed. Bytes beyond the serialized image must not be trusted.ArrayOfItemsSerDewritten by the application is the application's responsibility.Documentation only; no code changes.
🤖 Generated with Claude Code