Repository navigation
UI: exclude SYSTEM/ROUTING templates from Deploy Instance (#14414) - #14420
Open
nabassa1323 wants to merge 1 commit into
Open
nabassa1323 wants to merge 1 commit into
nabassa1323 wants to merge 1 commit into
Conversation
Damans227
reviewed
Oct 16, 2026
| return { | ||
| ...listTemplatesResponse, | ||
| template: templates, | ||
| count: templates.length |
Collaborator
There was a problem hiding this comment.
wont this break paging? the pager reads this count as the total, so with 25 templates it shows only the first 10 and no page 2
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14420 +/- ##
============================================
+ Coverage 20.39% 21.69% +1.29%
+ Complexity 21283 21281 -2
============================================
Files 6481 5988 -493
Lines 588040 545496 -42544
Branches 72021 63956 -8065
============================================
- Hits 119957 118355 -1602
+ Misses 455052 414340 -40712
+ Partials 13031 12801 -230
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Admins using Deploy Instance with
templatefilter=allcan see SYSTEMtemplates (e.g. Debian-based system VM templates) when filtering by guest OS.
This change filters out SYSTEM and ROUTING templates from the Deploy Instance
template list so they are not selectable for user VMs.
Fixes: #14414
Types of changes
How to test