Repository navigation
tests should only run when applicable for adv-sg zone in such env #7155
Description
ISSUE TYPE
- Documentation Report
- testing/CI
COMPONENT NAME
marvin
CLOUDSTACK VERSION
4.18
CONFIGURATION
advanced zone with security groups.
OS / ENVIRONMENT
SUMMARY
when an advanced zone with security groups is used to test for regressions, a lot of errors occur.
an example
ERROR: test suite for <class 'tests.smoke.test_router_dns.TestRouterDns'>
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/local/lib/python3.6/site-packages/nose/suite.py", line 210, in run
self.setUp()
File "/usr/local/lib/python3.6/site-packages/nose/suite.py", line 293, in setUp
self.setupContext(ancestor)
File "/usr/local/lib/python3.6/site-packages/nose/suite.py", line 316, in setupContext
try_run(context, names)
File "/usr/local/lib/python3.6/site-packages/nose/util.py", line 471, in try_run
return func()
File "/marvin/tests/smoke/test_router_dns.py", line 92, in setUpClass
zoneid=cls.zone.id)
File "/usr/local/lib/python3.6/site-packages/marvin/lib/base.py", line 3562, in create
return Network(apiclient.createNetwork(cmd).__dict__)
File "/usr/local/lib/python3.6/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2981, in createNetwork
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/local/lib/python3.6/site-packages/marvin/cloudstackConnection.py", line 381, in marvinRequest
raise e
File "/usr/local/lib/python3.6/site-packages/marvin/cloudstackConnection.py", line 376, in marvinRequest
raise self.__lastError
File "/usr/local/lib/python3.6/site-packages/marvin/cloudstackConnection.py", line 310, in __parseAndGetResponse
response_cls)
File "/usr/local/lib/python3.6/site-packages/marvin/jsonHelper.py", line 155, in getResultObj
raise cloudstackException.CloudstackAPIException(respname, errMsg)
marvin.cloudstackException.CloudstackAPIException: Execute cmd: createnetwork failed, due to: errorCode: 431, errorText:Only shared guest network can be created in security group enabled zone
this is not necessary as we know beforehand that these tests will fail.
Tests need to be properly tagged to not run in these environments.
STEPS TO REPRODUCE
EXPECTED RESULTS
test will not run
ACTUAL RESULTS
test runs and fails
Activity
weizhouapache commentedon Feb 1, 2023
good start !
@DaanHoogland
lak7 commentedon Feb 3, 2023
I would love to handle this issue. Can you assign this issue to me.
DaanHoogland commentedon Feb 3, 2023
go ahead @lak7 , create a PR and we'll go from there. Note however that creating a test environment with an advanced zone with security groups and a marvin test environment in no small feat if you are new to the project.
lak7 commentedon Feb 3, 2023
Thanks! I will try my best.
DaanHoogland commentedon Jun 5, 2024
@lak7 I am unassigning you . please feel free to pick up when ready anyway
adithyanms-debug commentedon Jan 26, 2026
Hey guys i am new to open source contribution is it great to work with this issue as a beginner. If i can how should i approach this
DaanHoogland commentedon Jan 27, 2026
@adithyanms-debug maybe this resolving this is not hard, but creating a list of tests that should not run in an advanced-zone with Security groups is. a regression test suite should be run against/inb such a zone and failures assessed to be genuine or due to not being applicable in such an environment. I will run such a test suite and link the results here.
#12198 (comment) should lead to the results that need addressing. Feel free to reclude yourself @adithyanms-debug , as it is maybe not so much a beginners issue.
github-actions commentedon Sep 5, 2026
This issue is stale because it has been open for 120 days with no activity. It may be removed by administrators of this project at any time. Remove the stale label or comment to request for removal of it to prevent this.