This repository was archived by the owner on Jan 20, 2021. It is now read-only.
Repository navigation
This repository was archived by the owner on Jan 20, 2021. It is now read-only.
[BUG] Migration of a VM (local storage) stuck on UI #906
Description
Describe the bug
When migrating a VM that is running on local storage the UI hangs on the VM migration pop-up; additionally, it is presented an error on UI and an event Error while migrating VMis created.
When closing the migration tab and refreshing the instance page then it is possible to see that the VM was correctly migrated.
To Reproduce
Steps to reproduce the behavior:
- Log in as Admin
- Migrate a VM
- See error message thrown at UI
- VM's migration tab hangs while waiting for completing migration (which has already completed)
- Close migration pop-up and refresh VM page
- Assert that VM was correctly migrated, despite UI saing otherwise at first
Screenshots
Example of the VM migration pop-up that stays waiting for migration:
Activity
shwstppr commentedon Dec 29, 2020
@GabrielBrascher not completely sure but this PR, #789, might solve the issue
But changes in the PR also rely on some backend changes which might fail with master
GabrielBrascher commentedon Dec 30, 2020
Thanks for the hint, @shwstppr.
I am not sure if #789 tackles this issue; from what I understood that PR deals only with stopped VMs being migrated on VMware clusters? Please correct me if I am wrong.
Adding a bit of information here, this issue was created due to tests on live migration of VMs running in KVM with local storage volumes; the migration itself worked fine, except by the fact of UI not dealing with the command response. The problem seems to be related to the UI not dealing with the expected response.
davidjumani commentedon Jan 5, 2021
@GabrielBrascher Could you share a screenshot of the error as well as the API response ? The form should be frozen while hitting the migrate API and then close since it is async and doesn't have to wait long. It might freeze if the API call returned an error which can be fixed
yadvr commentedon Jan 5, 2021
@GabrielBrascher can you check and close against next RC/master?
GabrielBrascher commentedon Jan 5, 2021
Thanks @rhtyd and @davidjumani for the update, I will check against next master.
yadvr commentedon Jan 5, 2021
@GabrielBrascher we're going to cut RC4 later today/tomorrow, can you test before that for possible blockers?
GabrielBrascher commentedon Jan 5, 2021
@rhtyd @davidjumani It still migrates succesfully on backend but keeps locked on the migration screen with an error message.
yadvr commentedon Jan 5, 2021
@davidjumani pl check on priority - did you PR introduce any regression?
davidjumani commentedon Jan 5, 2021
@GabrielBrascher Could you send a screenshot of the API response? @rhtyd Think it might be because
migrateVirtualMachineWithVolumewas called instead ofmigrateVirtualMachinesince while testing the previous PR there weren't any issuesGabrielBrascher commentedon Jan 5, 2021
@davidjumani you are right, the command called is
migrateVirtualMachineWithVolume; therefore, the response ismigratevirtualmachinewithvolumeresponse.davidjumani commentedon Jan 5, 2021
@GabrielBrascher Could you try it with #913 ?
GabrielBrascher commentedon Jan 5, 2021
Applying changes from #913 the message is
response.migratevirtualmachineresponse is undefineddavidjumani commentedon Jan 6, 2021
@GabrielBrascher Could you try checking again? It's working fine on my end for migrating with volumes as well
GabrielBrascher commentedon Jan 6, 2021
@davidjumani re-packed my test env and now it works, you are right. Thanks!