Repository navigation
Conversation
Follow-up to PR apache#73753: In test_task_state_store.py, test_set_nonexistent_dag_run_returns_404 receives a 404 from _validate_scope rather than set()'s ValueError. Update the docstrings to clarify this behavior, assert on the 404 detail message, and add test_set_task_state_store_domain_error_returns_404 to verify ValueError translation parity for PUT.
Eason09053360
approved these changes
Sep 30, 2026
Eason09053360
left a comment
Eason09053360
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch!
LGTM :)
Eason09053360
left a comment
Eason09053360
left a comment
Contributor
There was a problem hiding this comment.
One suggestion. Feel free to resolve it!
Remove test_set_nonexistent_dag_run_returns_404 and test_set_nonexistent_task_id_returns_404 from TestSetTaskState as their exact assertions and URLs are already parametrized and tested in TestUnknownTaskInstance.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #73753 based on reviewer feedback from @henry3260 and @Eason09053360:
test_set_task_state_store_domain_error_returns_404usingautospec=TrueonMetastoreBackend.setto verify domain-levelValueErrortranslation parity withPATCH.test_set_nonexistent_dag_run_returns_404andtest_set_nonexistent_task_id_returns_404as their scope validation behavior is already tested underTestUnknownTaskInstance::test_returns_404.related: #73753
Was generative AI tooling used to co-author this PR?
Generated-by: Antigravity following the guidelines