Repository navigation
[v3-3-test] Detect Dag subclasses in the Dag version inflation check (#72861) - #72898
Merged
Merged
Conversation
…72861) The check only recognized a Dag constructor when the callable resolved through a from-import of airflow's DAG or dag. A Dag built from a subclass, or reached through an aliased module import, produced no warnings at all — and because task detection keys off the same predicate, neither did any task inside its with-block. The Dag file is not imported yet when the check runs, so there is no object to test — only names and the file's own imports. The cost of leaning on names is an occasional false positive on something merely named like a Dag. (cherry picked from commit 1e2ad80) Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check only recognized a Dag constructor when the callable resolved
through a from-import of airflow's DAG or dag. A Dag built from a
subclass, or reached through an aliased module import, produced no
warnings at all — and because task detection keys off the same
predicate, neither did any task inside its with-block.
The Dag file is not imported yet when the check runs, so there is no
object to test — only names and the file's own imports. The cost of
leaning on names is an occasional false positive on something merely
named like a Dag.
(cherry picked from commit 1e2ad80)
Co-authored-by: Jed Cunningham 66968678+jedcunningham@users.noreply.github.com