Repository navigation
[v3-3-test] Fix airflow info --file-io uploading an empty report (#72707) - #72832
Merged
Merged
Conversation
) * Fix airflow info --file-io uploading an empty report The report was read back from rich's recording buffer, but the render ran inside a capture, and rich skips the record buffer while a capture is active. The command therefore uploaded a zero-byte file and reported success, for a command whose only purpose is producing that report. The console is built without a color system because the result is written to a file, where escape codes would be noise rather than formatting. * Update airflow-core/tests/unit/cli/commands/test_info_command.py Co-authored-by: rjgoyln <151457491+rjgoyln@users.noreply.github.com> * Pin the uploaded report width so it does not depend on the terminal The console only falls back to a fixed width when stdout is not a tty, so a report generated from a real terminal was laid out at that terminal's width and long path values were cut off in the uploaded file. --------- (cherry picked from commit 90787d5) Co-authored-by: Y-C <easoneason0905@gmail.com> Co-authored-by: Eason09053360 <185830721+Eason09053360@users.noreply.github.com> Co-authored-by: Henry Chen <henrychen@apache.org> Co-authored-by: rjgoyln <151457491+rjgoyln@users.noreply.github.com>
1 task done
henry3260
marked this pull request as ready for review
September 9, 2026 18:20
henry3260
requested review from
bugraoz93,
dheerajturaga,
henry3260 and
potiuk
as code owners
September 9, 2026 18:20
henry3260
approved these changes
Sep 9, 2026
Contributor
Author
|
Hi maintainer, this PR was merged without a milestone set.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The report was read back from rich's recording buffer, but the render ran
inside a capture, and rich skips the record buffer while a capture is active.
The command therefore uploaded a zero-byte file and reported success, for a
command whose only purpose is producing that report.
The console is built without a color system because the result is written to
a file, where escape codes would be noise rather than formatting.
Co-authored-by: rjgoyln 151457491+rjgoyln@users.noreply.github.com
The console only falls back to a fixed width when stdout is not a tty,
so a report generated from a real terminal was laid out at that
terminal's width and long path values were cut off in the uploaded file.
(cherry picked from commit 90787d5)
Co-authored-by: Y-C easoneason0905@gmail.com
Co-authored-by: Eason09053360 185830721+Eason09053360@users.noreply.github.com
Co-authored-by: Henry Chen henrychen@apache.org
Co-authored-by: rjgoyln 151457491+rjgoyln@users.noreply.github.com