Repository navigation
[v3-3-test] Fix missing HTTP access logs when api-server omits the core app (#72026) - #72808
Merged
Merged
Conversation
…re app (#72026) * Fix missing HTTP access logs when api-server omits the core app An api-server started without the core app -- for example `--apps execution`, the shape used to run the Task Execution API as its own deployment -- served requests but recorded none of them. That leaves the component every running task depends on for heartbeats, state transitions and XComs with no per-request telemetry, which is the primary signal for diagnosing heartbeat stalls. Both server backends disable their own access logger, and the built-in access loggers are muted in the logging config, all on the premise that HttpAccessLogMiddleware handles access logging. That premise only held while the middleware was installed by the core app branch, so no configuration could recover the records. Installing it for every apps selection makes the premise true again instead of adding a fourth conditional that would give execution-only deployments a different log format from every other deployment. * Lock in HttpAccessLog outermost ordering with a positional assertion * Trim redundant caveat from init_middlewares ordering note --------- (cherry picked from commit 860233f) Co-authored-by: manish1337 <78193094+manish1337@users.noreply.github.com> Co-authored-by: pierrejeambrun <pierre.jeambrun@astronomer.io>
1 task done
pierrejeambrun
marked this pull request as ready for review
September 9, 2026 16:21
pierrejeambrun
requested review from
bugraoz93,
choo121600,
ephraimbuddy,
henry3260,
jason810496,
pierrejeambrun,
rawwar and
shubhamraj-git
as code owners
September 9, 2026 16:21
vatsrahul1001
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An api-server started without the core app -- for example
--apps execution,the shape used to run the Task Execution API as its own deployment -- served
requests but recorded none of them. That leaves the component every running task
depends on for heartbeats, state transitions and XComs with no per-request
telemetry, which is the primary signal for diagnosing heartbeat stalls.
Both server backends disable their own access logger, and the built-in access
loggers are muted in the logging config, all on the premise that
HttpAccessLogMiddleware handles access logging. That premise only held while the
middleware was installed by the core app branch, so no configuration could
recover the records. Installing it for every apps selection makes the premise
true again instead of adding a fourth conditional that would give execution-only
deployments a different log format from every other deployment.
Lock in HttpAccessLog outermost ordering with a positional assertion
Trim redundant caveat from init_middlewares ordering note
(cherry picked from commit 860233f)
Co-authored-by: manish1337 78193094+manish1337@users.noreply.github.com
Co-authored-by: pierrejeambrun pierre.jeambrun@astronomer.io