Repository navigation
[v3-3-test] Load the correct DAG version when a task starts from a trigger (#69988) - #72614
Merged
Merged
Conversation
…igger (#69988) * Pin triggerer start_from_trigger DAG resolution to the dagrun's version * Resolve trigger Dag version via _version_from_dag_run for pinned/unpinned parity * Skip triggers whose task is missing from the resolved Dag version For an unpinned run the resolved (latest) Dag version may no longer contain a renamed or removed deferred task. get_task() then raised TaskNotFound, which nothing on the load_triggers path caught, killing the whole triggerer; assign_unassigned re-handed the same trigger to the restarted triggerer, producing a crash loop. Guard the lookup and fall through to the plain workload, mirroring the guard in the execution API. Also introduce DBDagBag.get_serialized_dag_model_for_run so the triggerer uses a public API instead of the private _version_from_dag_run helper, as requested in review. (cherry picked from commit aead443) Co-authored-by: Sean Ghaeli <58916776+seanghaeli@users.noreply.github.com>
vatsrahul1001
marked this pull request as ready for review
September 8, 2026 06:13
vatsrahul1001
requested review from
XD-DENG,
ashb,
dstandish and
hussein-awala
as code owners
September 8, 2026 06:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin triggerer start_from_trigger DAG resolution to the dagrun's version
Resolve trigger Dag version via _version_from_dag_run for pinned/unpinned parity
Skip triggers whose task is missing from the resolved Dag version
For an unpinned run the resolved (latest) Dag version may no longer
contain a renamed or removed deferred task. get_task() then raised
TaskNotFound, which nothing on the load_triggers path caught, killing
the whole triggerer; assign_unassigned re-handed the same trigger to the
restarted triggerer, producing a crash loop. Guard the lookup and fall
through to the plain workload, mirroring the guard in the execution API.
Also introduce DBDagBag.get_serialized_dag_model_for_run so the
triggerer uses a public API instead of the private _version_from_dag_run
helper, as requested in review.
(cherry picked from commit aead443)
Co-authored-by: Sean Ghaeli 58916776+seanghaeli@users.noreply.github.com