Repository navigation
[v3-3-test] Fix airflow connections test returning success exit code on failure (#72548) - #72583
Merged
Merged
Conversation
…on failure (#72548) The failure branch in connections_test only printed the error message without raising SystemExit(1), unlike the other two failure paths in the same function. Any script that checks the exit code of this command would treat a failed connection test as a success. (cherry picked from commit 2056378) Co-authored-by: Jyun-An Chen <jun930436@gmail.com>
henry3260
marked this pull request as ready for review
September 6, 2026 06:03
henry3260
requested review from
bugraoz93,
dheerajturaga,
henry3260 and
potiuk
as code owners
September 6, 2026 06:03
henry3260
approved these changes
Sep 6, 2026
vatsrahul1001
approved these changes
Sep 7, 2026
vatsrahul1001
pushed a commit
that referenced
this pull request
Sep 7, 2026
…on failure (#72548) (#72583) The failure branch in connections_test only printed the error message without raising SystemExit(1), unlike the other two failure paths in the same function. Any script that checks the exit code of this command would treat a failed connection test as a success. (cherry picked from commit 2056378) Co-authored-by: Jyun-An Chen <jun930436@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failure branch in connections_test only printed the error message
without raising SystemExit(1), unlike the other two failure paths in
the same function. Any script that checks the exit code of this
command would treat a failed connection test as a success.
(cherry picked from commit 2056378)
Co-authored-by: Jyun-An Chen jun930436@gmail.com