Repository navigation
Respect the limit search param in the task overview duration chart - #72147
Merged
bbovenzi merged 1 commit intoAug 31, 2026
Merged
Conversation
The duration chart on the task overview always requested the last 14 task instances, ignoring the number of dag runs the user picked. The dag details layout already writes that choice to the limit search param, and the dag overview page reads a value of its own, so the task page was the only view that could not be widened. Read the same limit search param the details layout writes, falling back to the same default of 10, so the chart follows the selector and can be shared through the URL. The remaining limit on the failed task instance query is left alone: that query only reads total_entries and never renders the rows it fetches.
warreee
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
August 27, 2026 11:48
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
bbovenzi
approved these changes
Aug 31, 2026
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Contributor
Backport failed to create: v3-3-test. View the failure log Run detailsNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
You can attempt to backport this manually by running: cherry_picker 4dae472 v3-3-testThis should apply the commit to the v3-3-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continueIf you don't have cherry-picker installed, see the installation guide. |
Contributor
Author
vatsrahul1001
pushed a commit
that referenced
this pull request
Sep 7, 2026
…72147) (#72357) The duration chart on the task overview always requested the last 14 task instances, ignoring the number of dag runs the user picked. The dag details layout already writes that choice to the limit search param, and the dag overview page reads a value of its own, so the task page was the only view that could not be widened. Read the same limit search param the details layout writes, falling back to the same default of 10, so the chart follows the selector and can be shared through the URL. The remaining limit on the failed task instance query is left alone: that query only reads total_entries and never renders the rows it fetches. (cherry picked from commit 4dae472)
vatsrahul1001
pushed a commit
that referenced
this pull request
Sep 7, 2026
…72147) (#72357) The duration chart on the task overview always requested the last 14 task instances, ignoring the number of dag runs the user picked. The dag details layout already writes that choice to the limit search param, and the dag overview page reads a value of its own, so the task page was the only view that could not be widened. Read the same limit search param the details layout writes, falling back to the same default of 10, so the chart follows the selector and can be shared through the URL. The remaining limit on the failed task instance query is left alone: that query only reads total_entries and never renders the rows it fetches. (cherry picked from commit 4dae472)
imrichardwu
pushed a commit
to imrichardwu/airflow
that referenced
this pull request
Sep 11, 2026
…pache#72147) The duration chart on the task overview always requested the last 14 task instances, ignoring the number of dag runs the user picked. The dag details layout already writes that choice to the limit search param, and the dag overview page reads a value of its own, so the task page was the only view that could not be widened. Read the same limit search param the details layout writes, falling back to the same default of 10, so the chart follows the selector and can be shared through the URL. The remaining limit on the failed task instance query is left alone: that query only reads total_entries and never renders the rows it fetches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The duration chart on the task overview always requested the last 14 task instances, ignoring the number of dag runs the user picked. The dag details layout already writes that choice to the limit search param, and the dag overview page reads a value of its own, so the task page was the only view that could not be widened.
Read the same limit search param the details layout writes, falling back to the same default of 10, so the chart follows the selector and can be shared through the URL.
The remaining limit on the failed task instance query is left alone: that query only reads total_entries and never renders the rows it fetches.
Before:
After:
Was generative AI tooling used to co-author this PR?
Helped-by: [Claude] following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.